some CSP fixes #2194
Merged
some CSP fixes #2194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployed to https://pr-2194.aam-digital.net/ |
|
The security endpoint seems to work now but as long as we don't have the correct hash, this still will send a bunch of reports to sentry and also mill the console. So is this really something we want to keep enabled? |
1 similar comment
|
The security endpoint seems to work now but as long as we don't have the correct hash, this still will send a bunch of reports to sentry and also mill the console. So is this really something we want to keep enabled? |
TheSlimvReal
approved these changes
Jan 25, 2024
TheSlimvReal
force-pushed
the
csp-impr
branch
from
97806ec to
47ee74b
Compare
|
🎉 This PR is included in version 3.30.0-master.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.30.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #1999
allow blob images and fix angular blocking CSP reports going to sentry
CSP configuration is a huge pain *** I still somehow couldn't get a new hash for the index.html script. And setting up nginx with nonces also doesn't look trivial ...